Would I be ethnically Chinese or Vietnamese?

Ethnicity refers not to just race, but also to culture. If you act according to Vietnamese customs, you're considered Vietnamese. Your birth nationatilty is Vietnamese, but is currently American. When they say Vietnamese-Chines, it is based on race.